-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS build #151
Fix macOS build #151
Conversation
Can we expand this to a larger feature for all platforms? |
Sure, I'll look into doing that. It'll probably require rebuilding |
@carson-katri is that because of Intel? |
It looks like it only builds for iOS/macOS in the Makefile: https://github.com/liveviewnative/liveview-native-core/blob/37d7970aaa3e0be32b40bf9ed895416ae17fc79b/Makefile.toml#L117 Should be able to update it for tvOS, etc. |
Ah ok I'll check into this |
I added support for watchOS. It depends on liveview-native/liveview-native-core#5 and a new release of the xcframework (@shadowfacts is this automated?) |
It is not currently automated. To release a new version you have to:
|
Ok, thanks. I'll get that uploaded. |
@shadowfacts The new version is released, so watchOS/macOS builds should be good to go |
Awesome, this looks good to me 👍 |
I updated the workflow to make sure the package at least builds on macOS/watchOS. No tests run for them atm. I also changed the saving of failed snapshots, they now are saved to the Report navigator in Xcode instead of writing to a temp directory. |
Disables features unavailable on macOS.