Add Pinata IPFS support, reuse task-runner classes #4
Conversation
drivers/ipfs.go
Outdated
| } | ||
|
|
||
| func (ostore *IpfsSession) ListFiles(ctx context.Context, dir, delim string) (PageInfo, error) { | ||
| panic("Listing is not supported by Pinata IPFS driver") |
There was a problem hiding this comment.
Can we return a single file listing or something from PinList here instead of panicking?
There was a problem hiding this comment.
I think it's hard to make meaningful listing function for IPFS, so I implemented 'get by CID' semantics into it.
|
@cyberj0g could you please remove me or @victorges from the reviewers? I think 2 reviewers are enough for this PR. Thanks! |
|
@leszko sure, but aren't we normally request review from anyone who familiar with project or technology, so least booked person could volunteer and the rest could ignore the request completely? |
No, that's not the case. Please check: https://www.notion.so/livepeer/PR-Review-Guidelines-63ef679c091943139367cf632bd5c6aa |
|
I think we never had time to properly discuss these guidelines, my opinion is that some points are a bit too far from open source flow for an open source project. But alright, it's better than too vague process, let's follow that. |
Adds IPFS support through Pinata API (#3). I reused
base.goandipfs.gofrom task-runner with insignificant modifications. TODO: remove these files fromtask-runner, asgo-toolsis already a dependency.