Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip rtmp2segment logic for Windows. #3239

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Nov 7, 2024

It broke the Windows builds and is not used anywhere other than Realtime Video AI.

CC: @j0sh I think you'll need to implement that part for Windows too at some point.

It broke the Windows builds and is not used anywhere other than Realtime Video AI
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.96839%. Comparing base (3b1b600) to head (9323ce1).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3239         +/-   ##
===================================================
+ Coverage   34.96560%   34.96839%   +0.00279%     
===================================================
  Files            135         135                 
  Lines          35901       35901                 
===================================================
+ Hits           12553       12554          +1     
+ Misses         22642       22641          -1     
  Partials         706         706                 
Files with missing lines Coverage Δ
media/rtmp2segment.go 0.00000% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1b600...9323ce1. Read the comment docs.

Files with missing lines Coverage Δ
media/rtmp2segment.go 0.00000% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leszko leszko merged commit f3e99e1 into master Nov 7, 2024
18 checks passed
@leszko leszko deleted the rafal/fix-windows-build branch November 7, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants