Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ticket EV validation on startup #3084

Closed
wants to merge 4 commits into from

Conversation

eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Jun 24, 2024

What does this pull request do? Explain your changes. (required)

This change validates the ticket EV of an orchestrator to ensure it is sufficient for the prices that are set during startup.

Specific updates (required)

  • Adds getLargestPrice to startup.go. This determines the largest price across all models, gateway prices and default price to verify if the -ticketEV is large enough.

How did you test each of these updates (required)

Started orchestrator:

  • Without -ticketEV 2999999999999 and with model price at 4768372. Verified it failed validation.
  • With -ticketEV 2999999999999 and verified it passed validation.

However, larger price values will not pass validation without a larger ticket EV being set. I added a recommendation in the log entry based on the current formula.

This change currently does not prevent dynamic price changes outside of valid ticketEV while the orchestrator is running.

Does this pull request close any open issues?

AI-461

Checklist:

@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants