Dynamic ticket EV validation on startup #3084
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This change validates the ticket EV of an orchestrator to ensure it is sufficient for the prices that are set during startup.
Specific updates (required)
getLargestPrice
to startup.go. This determines the largest price across all models, gateway prices and default price to verify if the-ticketEV
is large enough.How did you test each of these updates (required)
Started orchestrator:
-ticketEV 2999999999999
and with model price at4768372
. Verified it failed validation.-ticketEV 2999999999999
and verified it passed validation.However, larger price values will not pass validation without a larger ticket EV being set. I added a recommendation in the log entry based on the current formula.
This change currently does not prevent dynamic price changes outside of valid ticketEV while the orchestrator is running.
Does this pull request close any open issues?
AI-461
Checklist:
make
runs successfully./test.sh
pass