Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment_rpc: increase log level of payment creation. it's useful! #2843

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

iameli
Copy link
Contributor

@iameli iameli commented Aug 18, 2023

Increases the log level of payment creation from 6 to 3 - a request from @ecmulli for payment tracking

@ad-astra-video
Copy link
Collaborator

I agree! Makes it easy to pick up payments sent on the B from the logs.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2843 (8f6b38f) into master (3f62408) will decrease coverage by 0.02213%.
Report is 2 commits behind head on master.
The diff coverage is 20.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2843         +/-   ##
===================================================
- Coverage   56.72881%   56.70668%   -0.02213%     
===================================================
  Files             88          88                 
  Lines          19149       19160         +11     
===================================================
+ Hits           10863       10865          +2     
- Misses          7690        7699          +9     
  Partials         596         596                 
Files Changed Coverage Δ
cmd/livepeer/livepeer.go 47.61905% <0.00000%> (ø)
clog/clog.go 59.87261% <15.38462%> (-3.14109%) ⬇️
server/segment_rpc.go 78.23529% <100.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e5465...8f6b38f. Read the comment docs.

Files Changed Coverage Δ
cmd/livepeer/livepeer.go 47.61905% <0.00000%> (ø)
clog/clog.go 59.87261% <15.38462%> (-3.14109%) ⬇️
server/segment_rpc.go 78.23529% <100.00000%> (ø)

@thomshutt thomshutt merged commit a231510 into master Aug 22, 2023
17 checks passed
@thomshutt thomshutt deleted the eli/payment-log-levels branch August 22, 2023 11:59
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants