Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-control: cookie based access control #934

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

gioelecerati
Copy link
Member

No description provided.

@gioelecerati gioelecerati marked this pull request as ready for review October 30, 2023 12:11
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #934 (f356606) into main (4a3fced) will increase coverage by 0.25110%.
Report is 5 commits behind head on main.
The diff coverage is 42.85714%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #934         +/-   ##
===================================================
+ Coverage   51.02703%   51.27813%   +0.25110%     
===================================================
  Files             63          63                 
  Lines           6475        6533         +58     
===================================================
+ Hits            3304        3350         +46     
- Misses          2901        2911         +10     
- Partials         270         272          +2     
Files Coverage Δ
handlers/misttriggers/user_new.go 100.00000% <100.00000%> (ø)
middleware/gating.go 0.00000% <0.00000%> (ø)
clients/mist_client.go 54.42359% <0.00000%> (-0.88976%) ⬇️
mapic/mistapiconnector_app.go 18.62917% <43.13725%> (+5.77473%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3356c1b...f356606. Read the comment docs.

Files Coverage Δ
handlers/misttriggers/user_new.go 100.00000% <100.00000%> (ø)
middleware/gating.go 0.00000% <0.00000%> (ø)
clients/mist_client.go 54.42359% <0.00000%> (-0.88976%) ⬇️
mapic/mistapiconnector_app.go 18.62917% <43.13725%> (+5.77473%) ⬆️

@gioelecerati gioelecerati merged commit fa5c2c3 into main Oct 30, 2023
12 checks passed
@gioelecerati gioelecerati deleted the gio/access-control/cookie-based branch October 30, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants