Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always log at top level when pipeline errors #917

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

thomshutt
Copy link
Contributor

Previously we were swallowing the error when going to a fallback pipeline

@thomshutt thomshutt requested a review from mjh1 October 12, 2023 07:38
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #917 (f749348) into main (b6d2021) will increase coverage by 0.24839%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #917         +/-   ##
===================================================
+ Coverage   50.94838%   51.19677%   +0.24839%     
===================================================
  Files             63          63                 
  Lines           6432        6434          +2     
===================================================
+ Hits            3277        3294         +17     
+ Misses          2887        2873         -14     
+ Partials         268         267          -1     
Files Coverage Δ
pipeline/coordinator.go 77.77778% <100.00000%> (+0.09921%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d2021...f749348. Read the comment docs.

Files Coverage Δ
pipeline/coordinator.go 77.77778% <100.00000%> (+0.09921%) ⬆️

... and 1 file with indirect coverage changes

@thomshutt thomshutt merged commit d80308f into main Oct 12, 2023
12 checks passed
@thomshutt thomshutt deleted the always-log-pipeline-failure branch October 12, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants