Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcode: apply T re-init logic for last clipped segment #910

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

emranemran
Copy link
Collaborator

@emranemran emranemran commented Oct 10, 2023

TODO: need to test directly in Staging before merging.

@emranemran emranemran requested review from thomshutt and mjh1 October 10, 2023 06:12
@emranemran emranemran force-pushed the emran/re-init-for-last-segment branch from 00445d4 to efdde3f Compare October 10, 2023 06:14
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #910 (b8a0fed) into main (8dc484d) will increase coverage by 0.03056%.
The diff coverage is 80.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #910         +/-   ##
===================================================
+ Coverage   50.88730%   50.91786%   +0.03056%     
===================================================
  Files             63          63                 
  Lines           6424        6428          +4     
===================================================
+ Hits            3269        3273          +4     
  Misses          2887        2887                 
  Partials         268         268                 
Files Coverage Δ
transcode/transcode_jobs.go 90.00000% <100.00000%> (+0.60606%) ⬆️
transcode/transcode.go 37.30964% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc484d...b8a0fed. Read the comment docs.

Files Coverage Δ
transcode/transcode_jobs.go 90.00000% <100.00000%> (+0.60606%) ⬆️
transcode/transcode.go 37.30964% <0.00000%> (ø)

@emranemran emranemran force-pushed the emran/re-init-for-last-segment branch from a6344b4 to b8a0fed Compare October 11, 2023 06:37
@emranemran emranemran merged commit b6d2021 into main Oct 11, 2023
12 checks passed
@emranemran emranemran deleted the emran/re-init-for-last-segment branch October 11, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants