Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clip: fix clipping when start/end segments fall in same segment #907

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

emranemran
Copy link
Collaborator

No description provided.

Copy link
Contributor

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, retroactive by Thom/Max

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #907 (02d2bc0) into main (b3ad7f8) will increase coverage by 0.20992%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #907         +/-   ##
===================================================
+ Coverage   50.89634%   51.10626%   +0.20992%     
===================================================
  Files             63          63                 
  Lines           6415        6418          +3     
===================================================
+ Hits            3265        3280         +15     
+ Misses          2882        2871         -11     
+ Partials         268         267          -1     
Files Coverage Δ
video/clip.go 33.75796% <ø> (ø)
clients/manifest.go 41.90141% <0.00000%> (-0.44734%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ad7f8...02d2bc0. Read the comment docs.

Files Coverage Δ
video/clip.go 33.75796% <ø> (ø)
clients/manifest.go 41.90141% <0.00000%> (-0.44734%) ⬇️

... and 1 file with indirect coverage changes

@emranemran emranemran merged commit dd52162 into main Oct 9, 2023
12 checks passed
@emranemran emranemran deleted the emran/fix-same-segment-clip branch October 9, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants