manifest: add DISCONTINUITY tags to clip playlist #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A discontinuity tag is required in the clip playlist so that it shows the correct duration.
Codecov Report
@@ Coverage Diff @@
## main #904 +/- ##
===================================================
+ Coverage 50.95253% 51.14682% +0.19429%
===================================================
Files 63 63
Lines 6404 6409 +5
===================================================
+ Hits 3263 3278 +15
+ Misses 2874 2864 -10
Partials 267 267
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0xcadams
approved these changes
Oct 6, 2023
thomshutt
reviewed
Oct 9, 2023
| if isClip { | ||
| _, totalSegs := video.GetTotalDurationAndSegments(renditionPlaylist) | ||
| renditionPlaylist.Segments[1].Discontinuity = true | ||
| renditionPlaylist.Segments[totalSegs-1].Discontinuity = true |
There was a problem hiding this comment.
Will we get an Array Out Of Bounds for a single segment clip? Possibly not because of the weird array preallocation stuff of the playlist library, but probably good to guard against anyway
There was a problem hiding this comment.
Yup exactly what we ran into. Fixed here: dd52162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discontinuity tag is required in the clip playlist so that it shows the correct duration.