Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil panic #903

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix nil panic #903

merged 1 commit into from
Oct 6, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Oct 6, 2023

While testing locally I noticed that this line was panic'ing on localSourceFile.Name()

@mjh1 mjh1 requested a review from thomshutt October 6, 2023 10:56
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #903 (a220115) into main (0a68878) will decrease coverage by 0.11978%.
Report is 8 commits behind head on main.
The diff coverage is 1.66667%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #903         +/-   ##
===================================================
- Coverage   51.00439%   50.88461%   -0.11978%     
===================================================
  Files             63          63                 
  Lines           6372        6387         +15     
===================================================
  Hits            3250        3250                 
- Misses          2858        2873         +15     
  Partials         264         264                 
Files Coverage Δ
pipeline/ffmpeg.go 35.52124% <0.00000%> (ø)
clients/manifest.go 43.11594% <0.00000%> (+0.15565%) ⬆️
pipeline/coordinator.go 77.67857% <0.00000%> (-1.23299%) ⬇️
video/clip.go 34.64052% <2.22222%> (-2.16504%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eeb00c...a220115. Read the comment docs.

Files Coverage Δ
pipeline/ffmpeg.go 35.52124% <0.00000%> (ø)
clients/manifest.go 43.11594% <0.00000%> (+0.15565%) ⬆️
pipeline/coordinator.go 77.67857% <0.00000%> (-1.23299%) ⬇️
video/clip.go 34.64052% <2.22222%> (-2.16504%) ⬇️

@mjh1 mjh1 merged commit ee289a8 into main Oct 6, 2023
12 checks passed
@mjh1 mjh1 deleted the mh/fix-panic branch October 6, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants