Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcode: add logic to force a session re-init #902

Merged
merged 3 commits into from
Oct 6, 2023

transcode: only apply re-init logic for a clip request

6fa1d42
Select commit
Loading
Failed to load commit list.
Merged

transcode: add logic to force a session re-init #902

transcode: only apply re-init logic for a clip request
6fa1d42
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 6, 2023 in 0s

50.95253% (-0.05186%) compared to 0a68878

View this Pull Request on Codecov

50.95253% (-0.05186%) compared to 0a68878

Details

Codecov Report

Merging #902 (6fa1d42) into main (0a68878) will decrease coverage by 0.05186%.
Report is 9 commits behind head on main.
The diff coverage is 18.51852%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #902         +/-   ##
===================================================
- Coverage   51.00439%   50.95253%   -0.05186%     
===================================================
  Files             63          63                 
  Lines           6372        6404         +32     
===================================================
+ Hits            3250        3263         +13     
- Misses          2858        2874         +16     
- Partials         264         267          +3     
Files Coverage Δ
clients/broadcaster.go 0.00000% <ø> (ø)
clients/broadcaster_local.go 0.00000% <0.00000%> (ø)
pipeline/ffmpeg.go 35.38462% <0.00000%> (-0.13662%) ⬇️
clients/manifest.go 43.11594% <0.00000%> (+0.15565%) ⬆️
transcode/transcode.go 37.30964% <70.00000%> (+1.57631%) ⬆️
pipeline/coordinator.go 77.67857% <0.00000%> (-1.23299%) ⬇️
video/clip.go 34.64052% <2.22222%> (-2.16504%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eeb00c...6fa1d42. Read the comment docs.

Files Coverage Δ
clients/broadcaster.go 0.00000% <ø> (ø)
clients/broadcaster_local.go 0.00000% <0.00000%> (ø)
pipeline/ffmpeg.go 35.38462% <0.00000%> (-0.13662%) ⬇️
clients/manifest.go 43.11594% <0.00000%> (+0.15565%) ⬆️
transcode/transcode.go 37.30964% <70.00000%> (+1.57631%) ⬆️
pipeline/coordinator.go 77.67857% <0.00000%> (-1.23299%) ⬇️
video/clip.go 34.64052% <2.22222%> (-2.16504%) ⬇️