Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a button to close the chat window #740

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Conversation

govind-io
Copy link
Contributor

resolves issue #665

The new chat window looks like:
image

Copy link

changeset-bot bot commented Dec 23, 2023

🦋 Changeset detected

Latest commit: 42255c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023

CLA assistant check
All committers have signed the CLA.

@govind-io govind-io marked this pull request as draft December 23, 2023 16:37
@govind-io govind-io marked this pull request as ready for review December 23, 2023 16:58
@govind-io govind-io marked this pull request as draft December 23, 2023 17:00
@govind-io govind-io marked this pull request as ready for review December 23, 2023 17:44
@davidzhao davidzhao requested review from lukasIO and Ocupe December 23, 2023 19:26
@lukasIO
Copy link
Contributor

lukasIO commented Dec 30, 2023

thanks for the PR. I circled this back to our design department.
The Feedback is

  • "Messages" should be centered horizontally in the top, not in the remaining space.
  • Close button is more prominent than "Send", which hierarchically shouldn't be the case. I would try making it just the "X", and showing button bg on hover

@govind-io
Copy link
Contributor Author

I have made the below changes based on the feedback, please let me know if it looks fine or something else needs to be done:

  1. Messages is centered aligned horizontally in the complete space, isntead of remaining space
  2. Close button just shows "X" now untill hovered, when hovered it shows the background color.

Without hover on button:
image

With hover on the button:
image

Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Many thanks for your contribution! 👍

@lukasIO lukasIO merged commit 6ea54f8 into livekit:main Jan 2, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants