AVAudioEngine version AudioDeviceModule #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/client-sdk-swift into hiroshi/adm-audioengine2
bcherry
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
this looks good. i understand most of the guts of the change are really in webrtc-sdk/webrtc#158 - what's the process for getting that merged in so we can use it? Or are we comfortable shipping our SDK with the exp4 version for now?
…/client-sdk-swift into hiroshi/adm-audioengine2
|
Hi, @hiroshihorie , sorry but waiting for this fix for very long time. Thanks for your effort. |
|
@bcherry Feels pretty stable now I think I'll merge it . |
commit facb3ce Author: Hiroshi Horie <[email protected]> Date: Thu Jan 23 23:20:43 2025 +0900 Move debug string commit 81afdd1 Author: Hiroshi Horie <[email protected]> Date: Thu Jan 23 23:12:19 2025 +0900 Revert "temp use local lib" This reverts commit b1b79d2. commit c978bd3 Author: Hiroshi Horie <[email protected]> Date: Thu Jan 23 23:12:04 2025 +0900 Tests commit b1b79d2 Author: Hiroshi Horie <[email protected]> Date: Thu Jan 23 17:15:23 2025 +0900 temp use local lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using lib from webrtc-sdk/webrtc#158.
macOS will still use previous implementation at the moment. (Device selection etc not implemented yet)
New features
Advanced other audio ducking
Lower audio from other apps dynamically when voice activity is detected.
Muted talker detection
Detect voice activity even mic is off after calling
AudioManager.shared.prepareRecording().Provide custom AVAudioNode configuration for input and output through
onEngineWillConnectInputandonEngineWillConnectOutputhandlers.Early recording initialization with
AudioManager.shared.prepareRecording()without mic indicator turning on.Early mic input buffer capturing with
AudioManager.shared.startLocalRecording()without the need for Room and connection.Improvements
Correct mic muting logic without the requirement of restarting whole audio unit (previous implementation).
Correct audio session configuration timing. AudioDeviceModule requests configuration when it's required, instead of counting tracks and configuring it in advance (previous implementation).