Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] Gemini realtime for 1.0 #1420

Draft
wants to merge 7 commits into
base: dev-1.0
Choose a base branch
from
Draft

[draft] Gemini realtime for 1.0 #1420

wants to merge 7 commits into from

Conversation

jayeshp19
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9aa9ab8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

theomonnom
theomonnom reviewed Jan 29, 2025
View reviewed changes
livekit-plugins/livekit-plugins-google/livekit/plugins/google/beta/realtime/realtime_api.py Outdated
def _on_agent_speech_done(self, content: TranscriptionContent) -> None:
if not self._is_interrupted and content.response_id and content.text:
self.emit(
"agent_speech_transcription_completed",
Copy link
Member

@theomonnom theomonnom Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have those events anymore. This isn't supported yet by the baseclass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to think more about it but I think we should add conversation_item_added and conversation_item_removed events

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayeshp19 @theomonnom