Guard against undefined method errors

Not all errors returned here will have an error_type method. In some cases these errors are just structs.
liveh2o · May 5, 2017 · 676ed90 · 676ed90
1 parent f933f7a
commit 676ed90
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/active_remote/rpc_adapters/protobuf_adapter.rb b/lib/active_remote/rpc_adapters/protobuf_adapter.rb
@@ -38,6 +38,8 @@ def execute(rpc_method, request_args)
       private
 
       def protobuf_error_class(error)
+        return ::ActiveRemote::ActiveRemoteError unless error.respond_to?(:error_type)
+
         case error.error_type
         when ::Protobuf::Socketrpc::ErrorReason::BAD_REQUEST_DATA
           ::ActiveRemote::BadRequestDataError
@@ -60,7 +62,7 @@ def protobuf_error_class(error)
         when ::Protobuf::Socketrpc::ErrorReason::IO_ERROR
           ::ActiveRemote::IOError
         else
-          ActiveRemoteError
+          ::ActiveRemote::ActiveRemoteError
         end
       end