cta: docker API #149
Merged
cta: docker API #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
royra
commented
Jul 31, 2023
royra
commented
- passthrough API to docker on port 3001
- websocket impl for exec and logs
royra
force-pushed
the
cta-docker-proxy
branch
2 times, most recently
from
4c4c088
to
30ecfb0
Compare
Yshayy
approved these changes
Aug 1, 2023
| import Dockerode from 'dockerode' | ||
| import fetch from 'node-fetch' | ||
| import { inspect, promisify } from 'node:util' | ||
| import waitForExpect from 'wait-for-expect' |
There was a problem hiding this comment.
wait-for-expect seems to be not maintained.
Might worth using alternative or just copying the implementation. (it's a single file)
packages/compose-tunnel-agent/src/docker-proxy/ws/handlers/exec.ts
Outdated
Show resolved
Hide resolved
packages/compose-tunnel-agent/src/docker-proxy/ws/handlers/logs.ts
Outdated
Show resolved
Hide resolved
added 7 commits
August 1, 2023 16:27
- passthrough API to docker on port 3001 - websocket impl for exec and logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.