Add login and linking profile #111
Conversation
|
|
||
| export class TokenExpiredError extends Error { | ||
| constructor() { | ||
| super('Token is expired') |
There was a problem hiding this comment.
worth noting the expiry time in the message
| { headers: { 'Content-Type': 'application/json', Authorization: `Bearer ${tokens.access_token}` } } | ||
| ) | ||
|
|
||
| if (!orgsResponse.ok) throw new Error(`Could not fetch orgs from Livecycle API. ${orgsResponse.status}: ${orgsResponse.statusText}`) |
There was a problem hiding this comment.
should really use something like got to avoid this code duplication everywhere
|
|
||
| const orgs = await orgsResponse.json() as Org[] | ||
|
|
||
| let chosenOrg: Org |
There was a problem hiding this comment.
style nit - wrap in function chooseOrg(orgs, promptUserWithChooseOrg) to shorten and avoid let
|
From a user experience, it might be worth asking the user after login if they want to link the profile and use |
|
|
||
| logger.info('Opening browser for authentication') | ||
| try { await childProcessPromise(await open(responseData.verification_uri_complete)) } catch (e) { | ||
| logger.info(`Could not open browser at ${responseData.verification_uri_complete}`) |
There was a problem hiding this comment.
This should be a warning, and also include the error
| { headers: { 'Content-Type': 'application/json', Authorization: `Bearer ${tokens.access_token}` } } | ||
| ) | ||
|
|
||
| if (!orgsResponse.ok) throw new Error(`Could not fetch orgs from Livecycle API. ${orgsResponse.status}: ${orgsResponse.statusText}`) |
There was a problem hiding this comment.
Worth including the body of the response, easier to troubleshoot/support
| interval: number | ||
| ) => { | ||
| try { | ||
| while (true) { |
There was a problem hiding this comment.
you can use p-retry instead of while(true)
| logger.info(`Already logged in as: ${jose.decodeJwt(tokensMaybe.id_token).email} 👌`) | ||
| return | ||
| } | ||
| tokens = await deviceFlow(loginUrl, logger, clientId) |
No description provided.