Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show worker/supervisor ids in app supervision graph #449

Merged

Conversation

DiaanEngelbrecht
Copy link
Contributor

Hi there!

TLDR; I added labels to the process nodes to make it more clear what the processes represent.

I was using Kino.Process in Livebook to try and figure out how some elements of the Membrane RTC Engine work. I won't go into the details, but suffice to say this is a foreign code base to me, and it wasn't clear from the get go:

  • What the supervision tree looks like.
  • How it the internal genservers relate to each other.
  • How that ties into my phoenix app.

So I was poking around blindly until I got my RTC Engine's process's graphed with Kino. This is what it looked like for reference:
without_initial_call

Cool! So now I get to see the process layout, but I'm still blind as to what all this actually is. I still don't know what Membrane is doing. To get a bit more insight, changed the label for the PID node to also print out the node's id and got this:

with_id

This helped me relate my WebRTC endpoints with pid's and I also really like the insight it gives when you plot a Phoenix app's supervision tree.

@DiaanEngelbrecht DiaanEngelbrecht changed the title Added intial call to node text Added Process ID to node text Jun 22, 2024
lib/kino/process.ex Outdated Show resolved Hide resolved
@jonatanklosko jonatanklosko changed the title Added Process ID to node text Show worker/supervisor ids in app supervision graph Jun 24, 2024
Co-authored-by: Jonatan Kłosko <[email protected]>
@josevalim josevalim merged commit 467bb05 into livebook-dev:main Jun 24, 2024
1 check passed
@josevalim
Copy link
Contributor

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants