Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a :formatter option to Kino.DataTable.new/2 #441

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Add a :formatter option to Kino.DataTable.new/2 #441

merged 10 commits into from
Jun 12, 2024

Commits on Jun 10, 2024

  1. Support a formatter option for Kino.DataTable.new/2

    @kipcole9
    kipcole9 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e2370f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Change __column__ to __header__ 

    Make Kino.DataTable.value_to_string/2 private again
Make default formatter be &value_to_string/2 (no module)
    @kipcole9
    kipcole9 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2426e1e View commit details
    Browse the repository at this point in the history

  2. Remove :formatter option for Kino.DataTable.update/2

    @kipcole9
    kipcole9 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    44f68c5 View commit details
    Browse the repository at this point in the history

  3. Remove :formatter option for Kino.DataTable.update/2

    @kipcole9
    kipcole9 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1e9bc9d View commit details
    Browse the repository at this point in the history

  4. Return {:ok, string} or :default from optional formatter

    @kipcole9
    kipcole9 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    91ffd4f View commit details
    Browse the repository at this point in the history

  5. Add test case for data table formatter

    @kipcole9
    kipcole9 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9d9257e View commit details
    Browse the repository at this point in the history

  6. Update :formatter option docs

    @kipcole9
    kipcole9 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    40d7468 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Remove unused parameter key from value_to_string

    @kipcole9
    kipcole9 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    342661f View commit details
    Browse the repository at this point in the history

  2. Make data table formatter option test more explicit

    @kipcole9
    kipcole9 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9977c8f View commit details
    Browse the repository at this point in the history

  3. Update test/kino/data_table_test.exs

    @jonatanklosko
    jonatanklosko authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    4ab66b4 View commit details
    Browse the repository at this point in the history