fix: add notnull to welcome table (#250) #254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The welcome message being
null
in the database does not work well with the frontend. The frontend needs it to be notnull and expectsstring
, otherwise throws exceptions.@sualko I am not familiar with Nextcloud extensions. Is it enough to add another Migration.php by copy&paste&guess? :) I did not find a place where the migrations are referenced.