Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle auto-detected version strings with trailing information #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TyBrown
Copy link
Contributor

@TyBrown TyBrown commented Dec 16, 2022

Fixes #37

@TyBrown TyBrown force-pushed the auto-version-suffixes branch from 7ff6290 to 838ae1b Compare December 16, 2022 21:10
@TyBrown
Copy link
Contributor Author

TyBrown commented Dec 16, 2022

I fixed the golangci-lint stuff by upgrading the version, but there's a lot more failures than I can reasonably fix at this time, so I checked and ensured that I didn't introduce any new golangci-lint errors in the code I'm contributing in this PR compared to what is currently on master.

It also looks like the checks that GitHub Actions are running are against the base of the PR, so despite my fixing some of these issues, the checks are still failing in GitHub Actions. I believe this is due to the use of:

on: [pull_request_target]

instead of:

on: [pull_request]

@TyBrown
Copy link
Contributor Author

TyBrown commented Jan 27, 2023

@alexppg I hate to be a pest, but is there any chance of this getting reviewed/merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl automatic version detection fails if there is trailing version information
1 participant