Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type(bugfix): Fix MyHub input validation #2781

Merged
merged 1 commit into from
May 12, 2021

Conversation

saswatamcode
Copy link
Member

Proposed changes

This PR fixes MyHubEdit and MyHubConnect input issue where even wrong git URL and branch gets saved for later use(input fields show errors, but the user can still save) as mentioned here. Submit button now remains disabled until correct input is provided.
Screenshot 2021-05-12 at 8 44 10 AM

Also fixes broken copy icon image in MyHubEdit.
Screenshot 2021-05-12 at 8 35 03 AM

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode saswatamcode self-assigned this May 12, 2021
@codesniffy codesniffy bot added the size/M label May 12, 2021
Copy link
Member

@S-ayanide S-ayanide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@probot-auto-merge probot-auto-merge bot merged commit 2555d26 into litmuschaos:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants