Fixes issue #11 - An ArgumentNullException is thrown for the delete o…

…f an empty resource list
lithnet · Mar 17, 2017 · 3f7edc7 · 3f7edc7
1 parent 782e0aa
commit 3f7edc7
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/Lithnet.ResourceManagement.Client.UnitTests/DeleteTests.cs b/src/Lithnet.ResourceManagement.Client.UnitTests/DeleteTests.cs
@@ -7,6 +7,22 @@ namespace Lithnet.ResourceManagement.Client.UnitTests
     [TestClass]
     public class DeleteTests
     {
+        [TestMethod]
+        public void DeleteEmptyListResource()
+        {
+            ResourceManagementClient client = new ResourceManagementClient();
+
+            client.DeleteResources(new List<ResourceObject>());
+        }
+
+        [TestMethod]
+        public void DeleteEmptyListUniqueIdentifier()
+        {
+            ResourceManagementClient client = new ResourceManagementClient();
+
+            client.DeleteResources(new List<UniqueIdentifier>());
+        }
+
         [TestMethod]
         public void DeleteByID()
         {

diff --git a/src/Lithnet.ResourceManagement.Client/ServiceImplementation/ResourceClient.cs b/src/Lithnet.ResourceManagement.Client/ServiceImplementation/ResourceClient.cs
@@ -46,7 +46,7 @@ public void Put(IEnumerable<ResourceObject> resources)
             {
                 throw new ArgumentNullException(nameof(resources));
             }
-           
+
             using (Message message = MessageComposer.CreatePutMessage(resources.ToArray()))
             {
                 if (message == null)
@@ -107,7 +107,14 @@ public void Delete(IEnumerable<UniqueIdentifier> resourceIDs)
                 throw new ArgumentNullException(nameof(resourceIDs));
             }
 
-            using (Message message = MessageComposer.CreateDeleteMessage(resourceIDs.ToArray()))
+            UniqueIdentifier[] ids = resourceIDs.ToArray();
+
+            if (ids.Length == 0)
+            {
+                return;
+            }
+
+            using (Message message = MessageComposer.CreateDeleteMessage(ids))
             {
                 using (Message responseMessage = this.Invoke((c) => c.Delete(message)))
                 {