-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WoW Classic Support #279
Open
chowarth
wants to merge
25
commits into
lithammer:master
Choose a base branch
from
chowarth:wow-classic-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WoW Classic Support #279
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f56b2f8
Update gitignore
chowarth 968c2ea
Update gitmodules
chowarth 3e50f46
Update !BeautyCase toc version
chowarth a3cfb8f
Update !Colorz to work with Classic
chowarth 14523a3
Update nCore to work with Classic
chowarth 14cca85
Update nTooltip to work with Classic
chowarth 581189f
Update nCore some more to work with Classic
chowarth af24458
Update nChat to work with Classic
chowarth f241971
Update nCore dressroom to work with Classic
chowarth b363407
Update nMainBar to work with Classic
chowarth 5207817
Update gitignore and add missing file from previous commit
chowarth c01a04f
Update Colorz! to work with Classic
chowarth a98c765
Update nMinimap to work with Classic
chowarth 33c489d
Remove print statement
chowarth 7770b81
Revert "Remove print statement"
chowarth 57c1f2d
Remove print statement
chowarth 8caa4fe
Update nBuff to work with Classic
chowarth 62a7e74
Revert .gitmodules back now I've sorted out the ssh problems
chowarth 81869ab
Classic safety check in Colorz!
chowarth f456c80
Comment out options that aren't usable by Classic
chowarth 0ac9883
Fix toc version :/
chowarth 349bea4
Remove all non-Classic items from picomenu
chowarth 5e0ae34
Fix for minimap friends list throwing an error when a friend is playi…
chowarth 954738b
Remove print output
chowarth a6d719c
Fix minimap button not opening the guild tab
chowarth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
## Interface: 80200 | ||
## Interface: 11302 | ||
## Title: !Beautycase | ||
|
||
core.lua |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
## Interface: 80200 | ||
## Interface: 11302 | ||
## Title: !Colorz | ||
## Notes: Custom colors | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
## Interface: 80200 | ||
## Interface: 11302 | ||
## Title: Evl's Raid Status | ||
## Author: Evl | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
## Interface: 80200 | ||
## Interface: 11302 | ||
## Title: |cffCC3333 n|rBuff | ||
|
||
config.lua | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,15 +68,18 @@ end | |
|
||
-- Quick Join Button Options | ||
|
||
if cfg.enableQuickJoinButton then | ||
ChatAlertFrame:ClearAllPoints() | ||
ChatAlertFrame:SetPoint("BOTTOMLEFT", ChatFrame1Tab, "TOPLEFT", 0, 0) | ||
QuickJoinToastButton:ClearAllPoints() | ||
QuickJoinToastButton:SetPoint("BOTTOMLEFT", ChatAlertFrame, "TOPLEFT", 0, 0) | ||
else | ||
QuickJoinToastButton:SetAlpha(0) | ||
QuickJoinToastButton:EnableMouse(false) | ||
QuickJoinToastButton:UnregisterAllEvents() | ||
-- Classic: QuickJoinToastButton doesn't exist so add check | ||
if QuickJoinToastButton then | ||
if cfg.enableQuickJoinButton then | ||
ChatAlertFrame:ClearAllPoints() | ||
ChatAlertFrame:SetPoint("BOTTOMLEFT", ChatFrame1Tab, "TOPLEFT", 0, 0) | ||
QuickJoinToastButton:ClearAllPoints() | ||
QuickJoinToastButton:SetPoint("BOTTOMLEFT", ChatAlertFrame, "TOPLEFT", 0, 0) | ||
else | ||
QuickJoinToastButton:SetAlpha(0) | ||
QuickJoinToastButton:EnableMouse(false) | ||
QuickJoinToastButton:UnregisterAllEvents() | ||
end | ||
end | ||
|
||
-- Voice Chat Buttons | ||
|
@@ -261,6 +264,34 @@ local function ModChat(self) | |
chat.AddMessage = FCF_AddMessage | ||
end | ||
|
||
-- Classic: Brought over hiding the chat scroll buttons from a previous version | ||
local buttonUp = _G[self..'ButtonFrameUpButton'] | ||
if buttonUp ~= nil then | ||
buttonUp:SetAlpha(0) | ||
buttonUp:EnableMouse(false) | ||
end | ||
|
||
local buttonDown = _G[self..'ButtonFrameDownButton'] | ||
if buttonDown ~= nil then | ||
buttonDown:SetAlpha(0) | ||
buttonDown:EnableMouse(false) | ||
end | ||
|
||
local buttonBottom = _G[self..'ButtonFrameBottomButton'] | ||
if buttonBottom ~= nil then | ||
if (cfg.enableBottomButton) then | ||
buttonBottom:Hide() | ||
buttonBottom:ClearAllPoints() | ||
buttonBottom:SetPoint('BOTTOMLEFT', chat, -1, -3) | ||
buttonBottom:HookScript('OnClick', function(self) | ||
self:Hide() | ||
end) | ||
else | ||
buttonBottom:SetAlpha(0) | ||
buttonBottom:EnableMouse(false) | ||
end | ||
end | ||
|
||
for _, texture in pairs({ | ||
"ButtonFrameBackground", | ||
"ButtonFrameTopLeftTexture", | ||
|
@@ -272,12 +303,21 @@ local function ModChat(self) | |
"ButtonFrameBottomTexture", | ||
"ButtonFrameTopTexture", | ||
}) do | ||
_G[self..texture]:SetTexture(nil) | ||
-- Classic: These textures don't exist | ||
if _G[self..texture] then | ||
_G[self..texture]:SetTexture(nil) | ||
end | ||
end | ||
|
||
-- Modify the editbox | ||
|
||
for k = 3, 8 do | ||
--[[ | ||
Classic: Tried to find an elegent solution to SetTexture not being available on regions [3-8], | ||
but I could only get this to work if the loop to work if only regions [3-5] were done. | ||
|
||
Could be due to my limited WoW and Lua knowledge :s | ||
]]-- | ||
for k = 3, 5 do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Potentially: for k = 3, 8 do
local editBox = select(k, _G[self.."EditBox"]:GetRegions())
if editBox.SetTexture then
editBox:SetTexture(nil)
end
end |
||
select(k, _G[self.."EditBox"]:GetRegions()):SetTexture(nil) | ||
end | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
## Interface: 80200 | ||
## Interface: 11302 | ||
## Title: |cffCC3333 n|rChat | ||
## RequiredDeps: !Beautycase | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,12 @@ function nCore:Dressroom() | |
|
||
DressUpFrameCancelButton:SetText("Naked") | ||
DressUpFrameCancelButton:SetScript("OnClick", function() | ||
DressUpModel:Undress() | ||
-- Classic: Use DressUpModelFrame instead | ||
if DressUpModelFrame then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also |
||
DressUpModelFrame:Undress() | ||
else | ||
DressUpModel:Undress() | ||
end | ||
end) | ||
DressUpFrameResetButton:SetText("Clothed") | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if _G['UnitHasVehicleUI'] and UnitHasVehicleUI("player") then
? (orisRetail and ...
for better perf)