Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deployment guides for Docker and Supervisor #2679

Closed
wants to merge 0 commits into from

Conversation

WilliamStam
Copy link
Contributor

Description

Added guides for:

  • Docker
  • Supervisor
  • Supervisor cool alias
  • Setup on ubuntu 22.04

Close Issue(s)

Enhances: #2609

(this is an interim pr. i haven't used rst before and looking at formatting and cleanups - i also fail at proper punctuation)

@WilliamStam WilliamStam requested review from a team as code owners November 15, 2023 16:53
Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WilliamStam for this!

As this is, it's a bit bare though for our documentation. The documentation, the topical guide in particular, should not assume a lot of prior knowledge about these things and are meant to be in-depth guides, focusing on technical backgrounds, explaining why things are done a certain way, weighing alternatives, etc. These are meant to be learning oriented, trying to broaden the knowledge about a particular topic.

Currently, this is more of a condensed "how to" guide. I think this should either be am independent blog post (which we could link to from the docs) or, if you're up for it, changed to better fit the purpose of the documentation.

@WilliamStam
Copy link
Contributor Author

i dont mind beefing it out a bit more. would just need some feedback with stuff. the assuming that the setup is done gets covered in the long filename 1. i kinda thought to split it like that out incase somone wants to just see the supervisor stuff etc but aggreed

@JacobCoffee JacobCoffee changed the title Deployment guides for Docker and Supervisor docs: deployment guides for Docker and Supervisor Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants