Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deployment section for nginx-unit #2615

Merged
merged 10 commits into from
Nov 4, 2023
Merged

Conversation

Kumzy
Copy link
Member

@Kumzy Kumzy commented Nov 4, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

This add a new deployment folder in the documentation in the usage section as described in #2609.
Add a sub-section about using NGINX Unit to run litestar

Close Issue(s)

@Kumzy Kumzy requested review from a team as code owners November 4, 2023 08:43
docs/usage/deployment/nginx-unit.rst Outdated Show resolved Hide resolved
docs/usage/deployment/nginx-unit.rst Outdated Show resolved Hide resolved
docs/usage/deployment/nginx-unit.rst Outdated Show resolved Hide resolved
docs/usage/deployment/nginx-unit.rst Outdated Show resolved Hide resolved
docs/usage/deployment/index.rst Outdated Show resolved Hide resolved
docs/usage/deployment/nginx-unit.rst Outdated Show resolved Hide resolved
@JacobCoffee
Copy link
Member

Everything looks good to me except the move from Usage to Topics!

Thanks

Copy link
Member Author

@Kumzy Kumzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from usage to topic

Copy link

github-actions bot commented Nov 4, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2615

Copy link
Member Author

@Kumzy Kumzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to review comments

@JacobCoffee JacobCoffee added this pull request to the merge queue Nov 4, 2023
@JacobCoffee JacobCoffee removed this pull request from the merge queue due to the queue being cleared Nov 4, 2023
@JacobCoffee JacobCoffee merged commit 7512b9e into litestar-org:main Nov 4, 2023
15 checks passed
@JacobCoffee JacobCoffee changed the title docs: add nginx unit section docs: add deployment section for nginx-unit Nov 4, 2023
@Alc-Alc
Copy link
Contributor

Alc-Alc commented Nov 7, 2023

@all-contributors add @Kumzy to docs

Copy link
Contributor

@Alc-Alc

I've put up a pull request to add @Kumzy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants