Release 2.19.1 -- fix crash in IETF client (DPLPMTUD regression)

litespeedtech · Jul 29, 2020 · ef80a65 · ef80a65
1 parent b8fa619
commit ef80a65
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,5 @@
 2020-07-29
-    - 2.19.0
+    - 2.19.1
     - [FEATURE] DPLPMTUD support.  IETF connections now search for the
       maximum packet size, improving throughput.
     - [DEBUG] Record event in stream history when on_close() is called

diff --git a/docs/conf.py b/docs/conf.py
@@ -26,7 +26,7 @@
 # The short X.Y version
 version = u'2.19'
 # The full version, including alpha/beta/rc tags
-release = u'2.19.0'
+release = u'2.19.1'
 
 
 # -- General configuration ---------------------------------------------------

diff --git a/include/lsquic.h b/include/lsquic.h
@@ -25,7 +25,7 @@ extern "C" {
 
 #define LSQUIC_MAJOR_VERSION 2
 #define LSQUIC_MINOR_VERSION 19
-#define LSQUIC_PATCH_VERSION 0
+#define LSQUIC_PATCH_VERSION 1
 
 /**
  * Engine flags:

diff --git a/src/liblsquic/lsquic_full_conn_ietf.c b/src/liblsquic/lsquic_full_conn_ietf.c
@@ -1237,16 +1237,17 @@ lsquic_ietf_full_conn_client_new (struct lsquic_engine_public *enpub,
     }
     esfi = select_esf_iquic_by_ver(ver);
 
+    if (0 != ietf_full_conn_init(conn, enpub, flags,
+                                                enpub->enp_settings.es_ecn))
+        goto err2;
+
     if (base_plpmtu)
         conn->ifc_paths[0].cop_path.np_pack_size
                                 = base_plpmtu - TRANSPORT_OVERHEAD(!is_ipv4);
     else
         conn->ifc_paths[0].cop_path.np_pack_size
                                 = calc_base_packet_size(conn, !is_ipv4);
 
-    if (0 != ietf_full_conn_init(conn, enpub, flags,
-                                                enpub->enp_settings.es_ecn))
-        goto err2;
     if (token)
     {
         if (0 != lsquic_send_ctl_set_token(&conn->ifc_send_ctl, token,