fix: Compatibility issue between Common/ES Modules #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lufroes
had a problem deploying
to
Storybook Preview
GitHub Actions
Failure
literalpie
reviewed
Apr 8, 2025
| @@ -54,7 +51,7 @@ export const viteFinal: StorybookConfig["viteFinal"] = async ( | |||
|
|
|||
| export const previewAnnotations: StorybookConfig["previewAnnotations"] = ( | |||
| entry = [], | |||
| ) => [...entry, require.resolve("storybook-framework-qwik/preview.js")]; | |||
| ) => [...entry, join(dirname(fileURLToPath(import.meta.url)), "../preview.js")]; | |||
There was a problem hiding this comment.
This change seems to make yarn workspace qwik-app storybook fail to load for me
There was a problem hiding this comment.
5:00:14 PM [vite] Pre-transform error: Failed to resolve import "/Users/benjaminkindle/Developer/Web/storybook-framework-qwik/packages/storybook-framework-qwik/preview.js" from "/virtual:/@storybook/builder-vite/vite-app.js". Does the file exist?
5:00:14 PM [vite] Internal server error: Failed to resolve import "/Users/benjaminkindle/Developer/Web/storybook-framework-qwik/packages/storybook-framework-qwik/preview.js" from "/virtual:/@storybook/builder-vite/vite-app.js". Does the file exist?
Plugin: vite:import-analysis
File: /virtual:/@storybook/builder-vite/vite-app.js:7:81
| @@ -15,7 +15,7 @@ | |||
| "watch": "yarn workspace storybook-framework-qwik watch", | |||
| "build": "yarn workspace storybook-framework-qwik build", | |||
| "lint-all": "yarn workspaces foreach run fmt.check && yarn workspaces foreach run lint", | |||
| "storybook": "yarn workspace qwik-app storybook", | |||
| "storybook": "yarn workspace qwik-lib storybook", | |||
|
Is this still in progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #82.
Changes made:
preset.jsto Windows users (like me)previewAnnotationsfunction now do not relay on require anymorewrapForPnPfunction was removed since StoryBook now handle imports by its own