Replace filters by conditions in all queries #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
commented
Feb 12, 2024
NicolasMahe
commented
Feb 13, 2024
NicolasMahe
commented
Feb 13, 2024
NicolasMahe
commented
Feb 13, 2024
NicolasMahe
commented
Feb 13, 2024
NicolasMahe
commented
Feb 13, 2024
NicolasMahe
commented
Feb 13, 2024
antho1404
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Pretty much all good, one "issue" on the bids, and I still have the explore page to test more, @ismailToyran please have a look as well I might have missed some parts
NicolasMahe
force-pushed
the
chore/replace-filters-by-conditions
branch
from
dcdb9c0 to
934eeda
Compare
ismailToyran
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
One comment regarding components/Cart/Step/Selection.gql
Other than that looks really good. From the queries I've seen, it simplifies things pretty good 💪
antho1404
reviewed
Feb 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace filters by conditions in all queries.
As this is a big PR and it uses new conditions that I implemented myself on the backend, @antho1404 @ismailToyran can you check if there is no regression. Also you can familiarize yourself with the new way to filter data using the
conditionobject instead of thefilter.Only staging backend is updated. I'm waiting for first feedback to deploy the new version of the backend on prod.
Checklist
dev