Add signature modal and signature functionality #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
reviewed
Feb 1, 2024
There was a problem hiding this comment.
I noticed one issue where the account doesn't switch anymore and no signature is asked.
- Connect Wallet A
- Sign with Wallet A
- Go in the wallet app (eg Metamask)
- Switch account to account B
Result: Nothing happen
Expected: We should connect this wallet and reopen the signature modal like we do right now
Closed
|
The issue with changing account should be fixed with the latest commit. |
Closed
antho1404
approved these changes
Feb 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project organization
Description
Added “custom modal” asking the user to sign the message in its wallet, no more auto opening of Metamask
Checklist
dev