-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / Homepage banners added #542
Conversation
One feedback on the implementation, can we have a skeleton effect while loading the background image?
Adding a skeleton loader for the component will improve the UX and remove the bug feeling for the end users |
One additional point we could change maybe right now for consistency is to rename the section from “Starter kit configuration” to “Marketplace template configuration” as we stop using the “starter kit” wording. |
@antho1404 have any idea how we can improve the loading of the image? Also we don't have this loader on token cards either, same loading strategy. But we have background color for this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the priority + background should be enough.
Just one thing to fix to ensure existing platforms will not crash and then we are good to merge
…labs/starter-kit into feature/homepage-banners-added
Project organization
Description
By using dashboard, dashboard user can now add banner(s) to the homepage.
Checklist
dev