Logging callback exposed #2576
Open
Logging callback exposed #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ltetak
commented
Dec 19, 2024
| @@ -39,7 +39,7 @@ public CollectionPage(PageBuffer buffer, uint pageID) | |||
| public CollectionPage(PageBuffer buffer) | |||
| : base(buffer) | |||
| { | |||
| ENSURE(this.PageType == PageType.Collection, "page type must be collection page"); | |||
| ENSURE(this.PageType == PageType.Collection, "page type must be collection page, but it is {0}", PageType); | |||
There was a problem hiding this comment.
sorry this does not work, PageType argument is not replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a maintainer of an application using LiteDB, I would like to have insight into LiteDB behavior. So I added a simple callback that will expose logs. If not used then it should not make any performance difference. If used then it depends on the subscriber how this is handled.