This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
forked from bitpay/bitcore-node
-
Notifications
You must be signed in to change notification settings - Fork 68
Add Error Reporting for Transaction Posts & Bug Fixes/Optimizations #16
Open
OstlerDev
wants to merge
22
commits into
litecore-archive:v5.0
Choose a base branch
from
OstlerDev:ostlerdev-lcoin
base: v5.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix history sorting when paging results
add txIdList cache
Revert "add txIdList cache"
…xlist-cache add txIdList cache
This changes the P2P SendTransaction to use a JSON RPC call to Lcoin in order to detect transaction errors.
This prevents the transaction from getting stuck showing 0 confirmations as it currently does.
If the changes are merged into `ultragtx` then we should switch back, thus this temporary branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request pulls the latest changes from bitcore-node#v5.0 that makes the following changes
package.json
needs to be updated after Pass error along to the TX Broadcast RPC call if there was one ultragtx/lcoin#3 is accepted)In addition to the changes that BitPay made to bitcore-node, these additional changes have been made by myself:
litecore-node
to not process new Blocks after a restartPlease let me know if you have any questions, or if there are any changes that need to be made before this is pulled in.