Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add data/signals docs #1372

Merged
merged 23 commits into from
Oct 8, 2024
Merged

[docs] Add data/signals docs #1372

merged 23 commits into from
Oct 8, 2024

Conversation

justinfagnani
Copy link
Contributor

@justinfagnani justinfagnani commented Oct 1, 2024

First draft of docs for @lit-labs/signals

I added:

  • docs/data/signals.md
  • One playground sample
  • A blog post announcing the release

Because the package isn't published yet, the build and checks are going to fail for now. Once the content is approved, we can publish the package, the CI will go green, then merge the PR.

Copy link

@filimon-danopoulos filimon-danopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and a question

packages/lit-dev-content/site/docs/v3/data/signals.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/signals.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/signals.md Outdated Show resolved Hide resolved
Copy link
Contributor

@graynorton graynorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@justinfagnani justinfagnani merged commit 3dc7a65 into main Oct 8, 2024
13 of 15 checks passed
@justinfagnani justinfagnani deleted the signals-docs branch October 8, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants