Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example/until] replace call to jsonplaceholder with a static text #1337

Merged
merged 1 commit into from
May 30, 2024

Conversation

kadoshms
Copy link
Contributor

Currently the until directive playground example is broken due to the reliance on jsonplaceholder which is not stable.
Instead, simply await a timeout of 2 seconds, and return some static text.

Copy link

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! jsonplaceholder seems to be working fine for me for the moment, and I do like examples to have even a semblance of something close to a real example.. but reducing an external dependency probably is a good idea.

Perhaps down the line we can come up with an example that uses some async web API that doesn't depend on an external resource. Or we just add some mock data endpoint to lit.dev since we do have other examples that want to show case network requests.

@augustjk augustjk changed the title fix: replace call to broken jsonplaceholder with a static text [example/until] replace call to jsonplaceholder with a static text May 30, 2024
@augustjk augustjk merged commit fb937bb into lit:main May 30, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants