Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: upgrade guide decorator section #1199

Merged
merged 22 commits into from
Oct 6, 2023
Merged

v3: upgrade guide decorator section #1199

merged 22 commits into from
Oct 6, 2023

Commits on Oct 4, 2023

  1. Update the v3 upgrade guide, and v3 custom accessor guidance

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3e4caff View commit details
    Browse the repository at this point in the history

  2. code review feedback

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    70b0338 View commit details
    Browse the repository at this point in the history

  3. Augustine's excellent feedback

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e443443 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. apply feedback

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fa09a43 View commit details
    Browse the repository at this point in the history

  2. add explicit mention that babel 2018 decorators are not supported in … 

    …Lit 3
    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ef7061c View commit details
    Browse the repository at this point in the history

  3. focus the changes only on upgrading decorators from Lit 2.x

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e33edbc View commit details
    Browse the repository at this point in the history

  4. make hand written accessor guidance optional

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    18e4942 View commit details
    Browse the repository at this point in the history

  5. add optional standard decorator migration for babel section.

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    aa96cde View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c75a949 View commit details
    Browse the repository at this point in the history

  2. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e3dc21e View commit details
    Browse the repository at this point in the history

  3. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8b92c2e View commit details
    Browse the repository at this point in the history

  4. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c5d3a37 View commit details
    Browse the repository at this point in the history

  5. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2f463e1 View commit details
    Browse the repository at this point in the history

  6. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    3291587 View commit details
    Browse the repository at this point in the history

  7. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Justin Fagnani <[email protected]>
    @AndrewJakubowicz @justinfagnani
    AndrewJakubowicz and justinfagnani authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6e6fe0b View commit details
    Browse the repository at this point in the history

  8. fix some syntax issues and links

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    39136f5 View commit details
    Browse the repository at this point in the history

  9. remove old decorated getter section

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f56d864 View commit details
    Browse the repository at this point in the history

  10. fix links and heading nesting

    @AndrewJakubowicz
    AndrewJakubowicz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2799c11 View commit details
    Browse the repository at this point in the history

  11. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Augustine Kim <[email protected]>
    @AndrewJakubowicz @augustjk
    AndrewJakubowicz and augustjk authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0981c31 View commit details
    Browse the repository at this point in the history

  12. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Augustine Kim <[email protected]>
    @AndrewJakubowicz @augustjk
    AndrewJakubowicz and augustjk authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    59d116a View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: Augustine Kim <[email protected]>
    @AndrewJakubowicz @augustjk
    AndrewJakubowicz and augustjk authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6f3317e View commit details
    Browse the repository at this point in the history

  14. Update packages/lit-dev-content/site/docs/v3/releases/upgrade.md 

    Co-authored-by: Augustine Kim <[email protected]>
    @AndrewJakubowicz @augustjk
    AndrewJakubowicz and augustjk authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5d3dcac View commit details
    Browse the repository at this point in the history