Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: precompile source code to v8 bytecode before being written to the output file #25

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leodido
Copy link
Member

@leodido leodido commented Mar 8, 2023

This PR introduces a CI workflow that compiles the source code to v8 bytecode (via pkg).

It runs on a Linux host with QEMU emulation to generate executables for all supported architectures and platforms as per docs.

Cons

  • It's 20x slower than the actual building system (that uses --no-bytecode flag)

Pros

  • It may enable us to use ldid to sign all the binaries
  • It may enable us to simplify and speed up the release process
    • The post-build hooks would move the built binaries to the GoReleaser destination folders

  • I have read the contributing guidelines
  • I have written unit tests
  • I have made sure that the pull request is of reasonable size and can be easily reviewed

@reviewpad reviewpad bot added small Pull request is small ci labels Mar 8, 2023
@reviewpad
Copy link

reviewpad bot commented Mar 8, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

…eing written to the output file

Signed-off-by: Leonardo Di Donato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant