Predict function for logistic regression. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| y_pred = classifier.y_pred | ||
|
|
||
| # find the input to theano graph | ||
| inputs = graph.inputs([y_pred]) |
There was a problem hiding this comment.
I think we told we don't use that as this is for the DLT. In the __init__, keep a reference to input. Do that for each example to be consistent, but you don't need to add a predict() function for each example
| @@ -109,6 +109,9 @@ def __init__(self, input, n_in, n_out): | |||
| # parameters of the model | |||
| self.params = [self.W, self.b] | |||
|
|
|||
| # keep track of model input | |||
| self.input = input | |||
|
|
|||
There was a problem hiding this comment.
Can you check if this is needed for the other models? That way, all pickled files will have the needed information.
|
This should cover all the supervised learning scripts that have same structure. |
|
thanks. This made me discover that some class use self.x while others use self.input. I made a separate ticket for this gh-99 |
nouiz
added a commit
that referenced
this pull request
Jul 2, 2015
Predict function for logistic regression.
taneishi
pushed a commit
to taneishi/DBN_CPI
that referenced
this pull request
Nov 28, 2019
Predict function for logistic regression.
taneishi
pushed a commit
to taneishi/DBN_CPI
that referenced
this pull request
Feb 13, 2020
Predict function for logistic regression. Former-commit-id: c0217ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #79