Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing name of the Docker image, for locally created images #261

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

saemik94
Copy link
Contributor

@saemik94 saemik94 commented Aug 2, 2023

Summary

When Docker images are created locally, they do not have a digest. The name of the image then should be determined from the tag, but this accesses a non-existent value. Therefore no name is displayed:

missing_image_name

This pull request fixes this problem and the Docker image name is correctly displayed on the overview.

fixed_image_name

Proposed Changes

  • imageList.widget.js 52: image[2] evaluates undefined and therefore should be changed to image['RepoTags']

Checklist

  • I added tests
  • I updated the README if necessary
  • This PR introduces a breaking change
  • Fixed issue #
  • I added a picture of a cute animal cause it's fun

@lirantal lirantal self-requested a review August 2, 2023 13:57
@lirantal lirantal added the bug label Aug 2, 2023
@lirantal
Copy link
Owner

lirantal commented Aug 2, 2023

Looks good. Thank you for the fix @saemik94 🙏🏼

@lirantal lirantal merged commit a28fb73 into lirantal:main Aug 2, 2023
5 of 6 checks passed
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This PR is included in version 3.23.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@saemik94 saemik94 deleted the bugfix/missing_image_name branch August 2, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants