Container sort #244
Container sort #244
Conversation
Added support for a menu that sorts container statuses on the container page.
- Added sort by container status - Fixed a bug where the container menu was always showing behind the other container panels
# Conflicts: # src/screen.js # widgets/containers/containerList.widget.js
- Undo deletions
Removed comments
|
First time ever contributing to open source, sorry if the commit history is a bit messy. If you want me to change the key to open the sort menu / put the sort menu and the bug fix in separate PRs I can. |
| this.refreshList(); | ||
| } | ||
|
|
||
| // TODO refactor this | ||
| formatList (containers) { |
There was a problem hiding this comment.
I don't love what I had to do to this method. It's unfortunate that the library expects an array instead of an object, because I had to push the status to use it in a calculation later, then pop it.
| @@ -119,7 +119,7 @@ class myWidget extends baseWidget() { | |||
| } | |||
|
|
|||
| getWidget () { | |||
| return this.grid.gridObj.set(...this.grid.gridLayout, this.blessed.list, { | |||
There was a problem hiding this comment.
This was causing the actions menu to always be drawn behind the main container view, it was just not noticeable unless you resized the terminal window to specific screen sizes.
You can see in this screenshot the menu poking out to the right of the container status panel ^
|
@lirantal Is there anything you need me to do before you merge? |
|
@LawrenceB5477 thanks for the PR. Looks like nice work! There were some lint errors that I was able to fix and push to your branch. |
|
🎉 This PR is included in version 3.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
-Added a default sort option by active containers in the container view, and added the option to open up a sort menu to sort containers by status.
Proposed Changes
Checklist