Only report rows affected for DML statements #6706

wwillard7800 · 2025-02-05T22:29:30Z

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Fixes #3418

MalloD12

Changes look good to me.

wwillard7800 added the TypeEnhancement label Feb 5, 2025

wwillard7800 requested a review from filipelautert as a code owner February 5, 2025 22:29

wwillard7800 temporarily deployed to internal February 5, 2025 22:29 — with GitHub Actions Inactive

wwillard7800 marked this pull request as draft February 5, 2025 22:29

wwillard7800 temporarily deployed to internal February 5, 2025 22:35 — with GitHub Actions Inactive

wwillard7800 temporarily deployed to internal February 6, 2025 00:01 — with GitHub Actions Inactive

filipelautert self-assigned this Feb 6, 2025

filipelautert mentioned this pull request Feb 6, 2025

Please enhance "row(s) affected" output #3418

Open

wwillard7800 temporarily deployed to internal February 6, 2025 15:19 — with GitHub Actions Inactive

filipelautert approved these changes Feb 10, 2025

View reviewed changes

filipelautert requested a review from MalloD12 February 10, 2025 12:45

filipelautert marked this pull request as ready for review February 10, 2025 12:45

wwillard7800 added 4 commits February 10, 2025 09:45

Fix for rows affected inconsistencies

5bc1398

Added test

3ef9b9e

Handle new lines for matching DML statements

54c1bdc

Add another assertion to test

459ae68

filipelautert force-pushed the github-issue-3418 branch from ddee0e3 to 459ae68 Compare February 10, 2025 12:45

filipelautert temporarily deployed to internal February 10, 2025 12:45 — with GitHub Actions Inactive

MalloD12 approved these changes Feb 10, 2025

View reviewed changes

filipelautert requested review from rberezen and tati-qalified February 10, 2025 17:19