Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1521] dashboard: move delete logic to form_valid #1524

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[1521] dashboard: move delete logic to form_valid #1524

merged 1 commit into from
Feb 8, 2024

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Feb 1, 2024 •
edited
Loading

Fixes #1521

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@m4ra m4ra requested a review from goapunk February 1, 2024 17:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.85% 141/1097
🔴 Branches 14.86% 103/693
🔴 Functions 12.54% 44/351
🔴 Lines 20.57% 725/3525

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from a0961a1

@m4ra m4ra merged commit a10ef4e into main Feb 8, 2024
3 checks passed
@m4ra m4ra deleted the mk-2024-02-fix-delete-method-in-dashboard-mixin branch February 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk Awaiting requested review from goapunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom model delete method deprecated: after django upgrade
1 participant
@m4ra