Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments_async/comment_box: fix comment count plural not updating pro… #1519

Merged
merged 1 commit into from
Jan 24, 2024
Merged

comments_async/comment_box: fix comment count plural not updating pro… #1519

merged 1 commit into from
Jan 24, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Jan 23, 2024 •
edited
Loading

…perly

The comment count (on proposals for example) would only have the correct plural after refreshing. This should fix it

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk requested review from m4ra and hom3mad3 January 23, 2024 15:21
@github-actions GitHub Actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.85% 141/1097
🔴 Branches 14.86% 103/693
🔴 Functions 12.54% 44/351
🔴 Lines 20.54% 725/3529

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 5d10f87

@goapunk goapunk requested a review from philli-m January 24, 2024 07:45
philli-m
philli-m approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@philli-m philli-m merged commit aa44c6c into main Jan 24, 2024
3 checks passed
@philli-m philli-m deleted the jd-2024-01-comment-count-plural branch January 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

@m4ra m4ra Awaiting requested review from m4ra

@hom3mad3 hom3mad3 Awaiting requested review from hom3mad3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @philli-m