Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat duplicates #44

Merged
merged 5 commits into from
Sep 22, 2024
Merged

Feat duplicates #44

merged 5 commits into from
Sep 22, 2024

Conversation

elvira-cheng
Copy link
Contributor

Fix update_matadata.py to run option 'all';

Py script written to check duplicated guids and export as csv

MDavidson17
MDavidson17 requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@MDavidson17 MDavidson17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code! It's good to have this stored so it can be easily re-run in the future.

How hard do you think it would be to write some tests so that we can be confident it's still working correctly the next time we run it?

@elvira-cheng elvira-cheng merged commit b04ee34 into master Sep 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDavidson17 MDavidson17 MDavidson17 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elvira-cheng @MDavidson17