fix issue #151: bind not restarting when user uses closeBind #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing it for now, the error message doesnt match the close reason. There seems to be a race condition between the unbind start and the tcp disconnect. Ill reopen when I resolve this issue. |
linxGnu
reviewed
Sep 30, 2024
| @@ -127,6 +129,8 @@ func (t *transceivable) Close() (err error) { | |||
| if t.settings.OnClosed != nil { | |||
| t.settings.OnClosed(ExplicitClosing) | |||
| } | |||
|
|
|||
| t.wg.Wait() | |||
| } | |||
| return | |||
| } | |||
There was a problem hiding this comment.
Please update this function, reuse your nearly created closing
func (t *transceivable) Close() error {
t.closing(ExplicitClosing)
return nil
}There was a problem hiding this comment.
Some tests were failing after recommended change. So I added a returned error to the new closing () func.
func (t *transceivable) Close() (err error) {
return t.closing(ExplicitClosing)
}
func (t *transceivable) closing(state State) (err error) {
if atomic.CompareAndSwapInt32(&t.aliveState, Alive, Closed) {
...
// close underlying conn
err = t.conn.Close()
...
}
return
}
linxGnu
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pdu expires and the user returns true on closeBind, it should now call the close function with the proper state. This will allow OnClosed to be called and the bind to be restarted.
This also fixes the the transceiver context that is never closed.