Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable WebUI PORT #70

Closed
wants to merge 1 commit into from
Closed

Conversation

wansyu
Copy link

@wansyu wansyu commented Dec 22, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Add optional configurable WebUI PORT.

Benefits of this PR and context:

The current image cannot change the internal port of WebUI. This commit adds the PORT environment variable to avoid port conflicts that may be caused by hardcoded port when using the host network.

How Has This Been Tested?

I built an image from a Dockerfile and used it to create and run 2 containers simultaneously on the same host. Both Syncthing instances are successfully accessible through the GUI on the assigned ports, local discovery functions properly, and the instances are able to connect directly to other Syncthing instances on the local network.

Source / References:

[FEAT] Add option to set listen address for GUI #65

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70/shellcheck-result.xml

Tag Passed
amd64-v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70
arm64v8-v1.27.1-pkg-a42c0aec-dev-a0949c1c55e7de99f5a7ecf4db8626e255ecda5d-pr-70

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@RayBB
Copy link

RayBB commented Feb 5, 2024

@wansyu I posted on linuxserver discord asking about this and got the following response:

I don't particularly see an issue with making the port configurable for use in host networking mode, though I'm not really clear why it would be necessary, but we wouldn't make those changes to the Dockerfile, and we'd want to pick a clearer env name than just PORT

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented Jun 6, 2024

This pull request is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants