fix: Add missing icu-data-full for TextDecoder support in NodeJS #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
SIMULATAN
approved these changes
Mar 4, 2025
|
Better workaround: https://github.com/linuxserver/docker-mods/tree/universal-package-install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds
icu-data-fullsince some image uploads fail with an decoding error due to a broken call to the TextDecoder in NodeJS that expects legacy charset converters to be in place. in particular it wants to usewindows-1252as seen in the upstream GitHub issue.The upstream images are not affected, since they use static builds of NodeJS.
Benefits of this PR and context:
It fixes a bug, that was reported upstream, due do the way this image is build. It doesn't appear in upstream builds. We hope this reduces the number of bug reports for this issue.
How Has This Been Tested?
I build both versions of the image, with and without the issue. The issue was reproducible by copying multiple cells from LibreOffice Calc into HedgeDoc, resulting in an image upload.
When the package wasn't installed, it would fail due to the unsupported
windows-1252encoding.After installing the package, it works as expected.
Source / References:
hedgedoc/hedgedoc#5982
https://matrix.to/#/!oaRMJImPLfUnnXzwnN:shivering-isles.com/$bM9FdN50dj7YHXNJYhApnPYNyta7rxoKQeeqJLCQgmI?via=matrix.org&via=envs.net&via=mozilla.org