introduce BackgroundTaskService #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhumikaSaini-Amazon
suggested changes
May 22, 2024
Comment on lines
+27
to
+30
| /** | ||
| * Service to manage execution of tasks on Offline Node | ||
| */ | ||
| public class BackgroundTaskService implements LifecycleComponent { |
There was a problem hiding this comment.
Need to add @opensearch.internal.
Also, should we extend AbstractLifecycleComponent instead like the other services do, unless we plan to extend any other classes?
Suggested change
| /** | |
| * Service to manage execution of tasks on Offline Node | |
| */ | |
| public class BackgroundTaskService implements LifecycleComponent { | |
| /** | |
| * Service to manage execution of tasks on Offline Node | |
| * | |
| * @opensearch.internal | |
| */ | |
| public class BackgroundTaskService extends AbstractLifecycleComponent { |
Comment on lines
34
to
42
| private AsyncBackgroundTaskFetch backgroundTaskFetch; | ||
| /** | ||
| * TaskClient used to interact with TaskStore/Queue for Task Management and Coordination | ||
| */ | ||
| private final TaskClient taskClient; | ||
| /** | ||
| * Provides Corresponding TaskWorker to execute for each Task | ||
| */ | ||
| private final Map<TaskType, TaskWorker> taskWorkerMap; |
There was a problem hiding this comment.
Suggested change
| private AsyncBackgroundTaskFetch backgroundTaskFetch; | |
| /** | |
| * TaskClient used to interact with TaskStore/Queue for Task Management and Coordination | |
| */ | |
| private final TaskClient taskClient; | |
| /** | |
| * Provides Corresponding TaskWorker to execute for each Task | |
| */ | |
| private final Map<TaskType, TaskWorker> taskWorkerMap; | |
| private AsyncBackgroundTaskFetch backgroundTaskFetch; | |
| /** | |
| * TaskClient used to interact with TaskStore/Queue for Task Management and Coordination | |
| */ | |
| private final TaskClient taskClient; | |
| /** | |
| * Provides Corresponding TaskWorker to execute for each Task | |
| */ | |
| private final Map<TaskType, TaskWorker> taskWorkerMap; |
Comment on lines
+55
to
+59
| @Override | ||
| public void stop() { | ||
| backgroundTaskFetch.close(); | ||
| backgroundTaskFetch.cancel(); | ||
| } |
There was a problem hiding this comment.
close() is calling cancel() internally. Do we need the explicit cancel?
Suggested change
| @Override | |
| public void stop() { | |
| backgroundTaskFetch.close(); | |
| backgroundTaskFetch.cancel(); | |
| } | |
| @Override | |
| public void stop() { | |
| backgroundTaskFetch.close(); | |
| } |
Comment on lines
+66
to
+69
| @Override | ||
| public Lifecycle.State lifecycleState() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Why are we returning null?
Comment on lines
+71
to
+79
| @Override | ||
| public void addLifecycleListener(LifecycleListener listener) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void removeLifecycleListener(LifecycleListener listener) { | ||
|
|
||
| } |
|
|
||
| } | ||
|
|
||
| public void maybeExecuteTasks() { |
There was a problem hiding this comment.
nit
Suggested change
| public void maybeExecuteTasks() { | |
| public void maybeExecuteUnassignedTasks() { |
| } | ||
| } | ||
|
|
||
| private class AsyncBackgroundTaskFetch extends AbstractAsyncTask { |
| } | ||
| } | ||
|
|
||
| private class AsyncBackgroundTaskFetch extends AbstractAsyncTask { |
There was a problem hiding this comment.
Should we name this BackgroundTaskFetch or AsyncTaskFetch, unless the current name is intentional?
Comment on lines
85
to
87
| if (taskClient.claimTask(task.getTaskId())) { | ||
| taskWorkerMap.get(task.getTaskType()).executeTask(task); | ||
| } |
There was a problem hiding this comment.
Should this be synchronized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.