wayland: send key-down events for modifier keys #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, Muffin sends key-up events for modifier keys but no key-down event. This breaks applications that use a modifier key standalone, such as the Shift-click functionality in browsers, games which use modifier keys seperately, and Wine, where modifiers are rendered completely non-functional due to how its input model works. This commit fixes those issues. Closes: linuxmint/wayland#1
|
This fixed some issues I was having with wine/proton and the game not recieving modifier keys (Shift, Control, or Alt) However it causes an unexpected behavior with the meta [windows] key: The menu opens on keydown, thus causing keybinds based on meta to be hard to trigger (it will trigger if closing the menu) This includes window movement shortcuts (meta-left/right) as well as custom shortcuts I have to launch apps) (Edit for reference I'm currently working with the supplied patch plus a workaround of my own to still blocks SuperL/R so windows key shortcuts work, since at least currently only the desktop manager has shutcuts attatched to this key) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my post on the linked issue for details.
Closes: linuxmint/wayland#1